fix(plugin): derive missing crystallization summaries - #2222

🤖 Open Code Review

Target: PR #2222
Task: f0d912ead9bac289
Base: main
Head: fix/issue-2143-crystallize-summary-fallback

🔍 OpenCodeReview found 1 issue(s) in this PR.

1. apps/memos-local-plugin/core/skill/crystallize.ts (L369)

String.prototype.slice counts UTF-16 code units, not Unicode code points or grapheme clusters. For content containing multi-byte characters (e.g., Chinese, Japanese, Korean, emoji), this can silently split a surrogate pair and produce a malformed string. Consider using a Unicode-aware truncation, such as [...summarySource].slice(0, MAX_SUMMARY_LENGTH).join('') (splits by code point), or at minimum document that the limit is in code units.

  const summary = summarySource.slice(0, MAX_SUMMARY_LENGTH);

  const summary = [...summarySource].slice(0, MAX_SUMMARY_LENGTH).join("");

Generated by cloud-assistant via Open Code Review.

✅ Automated Test Results: PASSED

All tests passed (9/9 executed). memos_local_plugin/unit: 9/9. Duration: 3s [advisory, non-gating] AI-generated tests on branch test/auto-gen-32083f8dbbd21f66-20260805162117: 19/19 passed — these do NOT affect the PR verdict; review the branch manually.

Branch: fix/issue-2143-crystallize-summary-fallback

Updated this PR at a1dcfb2c to address both unresolved OCR findings.

Changes:

• select the first sanitized summary source, then apply the 200-character cap uniformly to explicit and derived summaries
• remove the unreachable optional/static fallback; displayTitle is already guaranteed non-empty
• add a regression test for an explicit 250-character summary (observed failing before the fix, passing after)

Merge status:

• the PR is already based on the latest main (0 behind / 1 ahead)
• merge-tree completed without conflicts

Local verification:

• focused crystallization suite: 10/10 passed
• complete local-plugin suite: 159 files, 1305 passed, 2 skipped
• npm run lint: passed
• npm run build: passed
• git diff --check: passed

Fresh OCR and AutoTest checks are pending. Python Actions run: https://github.com/MemTensor/MemOS/actions/runs/31122705498 (16 jobs queued while GitHub Actions is under a major outage).

✅ Automated Test Results: PASSED

All tests passed (10/10 executed). memos_local_plugin/unit: 10/10. Duration: 3s [advisory, non-gating] AI-generated tests on branch test/auto-gen-afc7396792f82328-20260807012102: 24/25 passed, 1 failed — these do NOT affect the PR verdict; review the branch manually.

Branch: fix/issue-2143-crystallize-summary-fallback

Thanks @syzsunshine219 for updating the branch in a1dcfb2c and validating the full plugin suite.

I kept that normalization fix and addressed the remaining OCR finding in 6e824e1c:

• extracted the shared 200-character cap to MAX_SUMMARY_LENGTH;
• retained the existing source priority and uniform clamp for explicit and derived summaries;
• added a regression proving a 250-character retrieval_blurb fallback is sanitized and clamped to 200 characters.

Verification:

• npm --prefix apps/memos-local-plugin test -- tests/unit/skill/crystallize.test.ts -> 11 passed
• npm --prefix apps/memos-local-plugin run lint -> passed
• npm --prefix apps/memos-local-plugin run build -> passed
• git diff --check -> passed

The complete local-plugin unit run could not complete in this local Node 26 environment because the existing better-sqlite3 native binding is unavailable for Node ABI 147. It reported 955 passed before the database-backed failures. This is the same environment limitation already documented for the earlier branch validation and is unrelated to the two crystallization files.

CI update for run 31557357464:

• all 8 macOS and all 4 Windows jobs passed;
• all 4 Ubuntu jobs stopped before build, Ruff, or tests on the unchanged src/memos/embedders/cache.py top-level cachetools import;
• Open Code Review passed with one non-blocking finding;
• AutoTest reported an environment issue before tests because its SSH clone failed with kex_exchange_identification: Connection closed by remote host.

I have kept the unrelated core/optional dependency issue out of this PR.

⚠️ Automated Test Results: ENV ISSUE

The test environment encountered an issue that requires manual attention.

Details: Executor error: Command failed: git clone --depth 1 --branch fix/issue-2143-crystallize-summary-fallback git@github.com:RerankerGuo/MemOS.git /data/test-workspaces/f0d912ead9bac289/repo
Cloning into '/data/test-workspaces/f0d912ead9bac289/repo'...
nc: read failed (0/4): Broken pipe
kex_exchange_identification: Connection closed by remote host
Connection closed by UNKNOWN port 65535
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Branch: fix/issue-2143-crystallize-summary-fallback